Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link: Catch all errors in resolve_types #266

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

ales-erjavec
Copy link
Collaborator

Issue

Ref: biolab/orange3#6410 (comment)

Any error can happen in the link type resolution (i.e. when dragging a new link in the canvas).

Changes

Catch all errors in resolve_types

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (61fe8c1) 74.91% compared to head (987a135) 74.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files          97       97           
  Lines       20696    20696           
=======================================
  Hits        15504    15504           
  Misses       5192     5192           
Impacted Files Coverage Δ
orangecanvas/scheme/link.py 83.12% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Any runtime error can happen at type import.
@janezd janezd assigned janezd and markotoplak and unassigned janezd Apr 21, 2023
@markotoplak markotoplak merged commit 11e049f into biolab:master Apr 21, 2023
21 checks passed
@ales-erjavec ales-erjavec deleted the resolve-types-catch-errors branch May 19, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants