Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of inputs with multiple=True mixes when one of them becomes None #86

Open
janezd opened this issue Feb 16, 2020 · 0 comments
Open
Labels

Comments

@janezd
Copy link
Contributor

janezd commented Feb 16, 2020

(Written by @markotoplak; moved from biolab/orange3#4215).

Describe the bug
When a user connects widgets to the multiple-input widget, these inputs appear in the widget in the order as they were connected. If then, one of the inputs becomes None, the receiving widget does not see them. If, then, it is set to something != None, the order changed.

To Reproduce

Make a workflow like this. Take care that you select things first in the lower Data Table, and then connect this output first to the Table on the right. The order of tabs is going to be (selection, the who DS).

out

Now, clear selection in the lower Table, and select something in it. The order of tabs in the right table changed.

I first discovered this with the Python Script widget, where this was more painful.

Expected behavior
The order should stay the same and the receiving widget should also see empty connection. Possible solution: "None"s are not filtered, but passed forward.

Orange version:
master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant