Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concoct: fix sklearn version #42187

Merged
merged 7 commits into from
Aug 8, 2023
Merged

Concoct: fix sklearn version #42187

merged 7 commits into from
Aug 8, 2023

Conversation

prototaxites
Copy link
Contributor

Concoct fails with newer versions of sklearn. Fixes the sklearn version in the concoct recipe to a compatible version.

BinPro/CONCOCT#323


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@prototaxites
Copy link
Contributor Author

@bioconda/core Any idea why this is failing? I can't for the life of me see any syntax problems in the meta.yaml file that would cause linting to fail!

@BiocondaBot
Copy link
Collaborator

Reposting for @prototaxites to enable pings (courtesy of the BiocondaBot):

@bioconda/core Any idea why this is failing? I can't for the life of me see any syntax problems in the meta.yaml file that would cause linting to fail!

@prototaxites
Copy link
Contributor Author

Fixed the issue - removed {{ mpi }} from meta.yaml. Not quite sure why it was there - looking at the CONCOCT documentation, there is no dependency on MPI that I can see!

@prototaxites
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Aug 7, 2023
@mencian
Copy link
Contributor

mencian commented Aug 8, 2023

Thank you! @prototaxites

@mencian mencian merged commit ac4f4ba into bioconda:master Aug 8, 2023
5 checks passed
@prototaxites prototaxites deleted the concoct branch August 8, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants