Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ObserveRouters GRPC Service #454

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

margau
Copy link
Contributor

@margau margau commented Nov 21, 2023

This PR shall allow a streaming update (and removing) of routers with their VRFs, improving the possibility of chaining a ris-mirror behind a RIS while automatically updating the targets.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e48eb2) 54.34% compared to head (ed69fe7) 52.79%.
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   54.34%   52.79%   -1.56%     
==========================================
  Files         146      152       +6     
  Lines        7901     8160     +259     
==========================================
+ Hits         4294     4308      +14     
- Misses       3401     3646     +245     
  Partials      206      206              
Flag Coverage Δ
unittests 52.79% <ø> (-1.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants