Binsync Server Implementation #348
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahaloz
reviewed
Jan 8, 2024
mahaloz
reviewed
Jan 8, 2024
Renamed item in atomic git action to GitServer. Probably easier to just copy over stuff from the client and delete whatever I don't need. Also, one small type change for iterable repos.
Temporarily commented out a property for has_remote. Added some logic to create and shut down the server. Currently doesn't handle calling of any atomic git actions. I still need to handle the scheduler stuff.
Currently, just added a flag to use the server versions of functions if a client flag is on. My echo function works, but nothing with the atomic decorator works for now. However, basic communication works. And the client is able to shut the server down. There's some TODOs that need to be taken care of. Mainly the fact that if the server address is in use then attempt to create a proxy instead of create a full server.
Basically just hijacked the code to test the client, and I'm using that to quickly test, since making a binja connection every time would be a pain to debug.
|
Okay, I copied over the client code to the git server, since I figured it'd be easier to delete stuff I wasn't using later. Currently able to spin up an XMLRPC server, tested it with 1 client and non atomic calls work. There's a line I forgot to change that's making it accept only 1 client. Will change that next commit. For the time being I just tacked on the atomic git action decorator to the server, that's probably wrong, so the commits are heavily WIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is aimed towards solving #346.
TODO: