Add working pagination to proj #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agination framework, fix filtering
|
Hi @jay-bis, thanks for figuring this out. Is there a way you can test this with the updated repo? I tried to pull down your changes & merge them myself, but got an error which I'm assuming is due to the updated Meteor version. |
|
Hi, @jay-bis. Are you participating in Hacktoberfest this year? If so, would love to add your contribution to the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accomplished this by using alethes' meteor-pages package, which made it fairly straightforward to get the pagination working. I had to reformat the currentProsecutors template, as well as add a few new templates in order to get everything working. I also had to change the way filtering was working, but it seems to work well!
I have the perPage attribute set to 10 right now, but that can always be changed. In the future, there would also be the ability to sort by different attributes (date appointed, alphabetical, etc.) or have the user change the perPage attribute.