Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation choices/nomenclature #2510

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

eld120
Copy link
Collaborator

@eld120 eld120 commented Dec 9, 2023

Wasn't paying close enough attention previously to the translation choices nomenclature. Changed to the following:

Native Spelling (localization setting)

# for example if localization is set to 'en'
English 
Nederlands (Dutch)

# for example if localization is set to 'nl'
English (Engels)
Nederlands 
  • The localized translation is always in parentheses for translation choices
  • The language choice before the parentheses is always written in it's native script and spelling so that native speakers can easily identify their preference

@sethherr
Copy link
Member

sethherr commented Dec 9, 2023

This PR looks like it updates the spec to be what we want it to be!

However, main is broken right now. I updated the spec to match the current situation (in #2512), and merged it.

(so now you'll have to deal with the merge conflict, sorry/not sorry)

@sethherr
Copy link
Member

sethherr commented Dec 10, 2023

Also, there are now some specs that need to be uncommented in spec/requests/locale_detection_request_spec.rb

(from 174e9f2 - other changes to fix main)

@eld120
Copy link
Collaborator Author

eld120 commented Dec 13, 2023

I looked at the spec in spec/requests/locale_detection_request_spec.rb and the tests that were commented out seemed to be mistakenly labelled as nb/norwegian where they should have been es/spanish - basing this off of the expected test results. Updated and running tests

@sethherr
Copy link
Member

  1. Do the tests fully cover nl, nb and es ?
  2. It looks like you still have to add the spanish test back in spec/helpers/localization_helper_spec.rb (see here, sorry should have commented it out not deleted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants