Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bikes search switch to js #2467

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/javascript/packs/bikes_search.js
Expand Up @@ -3,7 +3,7 @@ import ReactDOM from "react-dom";

import ErrorBoundary from "@honeybadger-io/react";

import SecondarySearches from "../scripts/bikes_search/SecondarySearches";
import BikeSearches from "../scripts/bikes_search/bike_searches";
import honeybadger from "../scripts/utils/honeybadger";

document.addEventListener("DOMContentLoaded", () => {
Expand All @@ -14,7 +14,7 @@ document.addEventListener("DOMContentLoaded", () => {

ReactDOM.render(
<ErrorBoundary honeybadger={honeybadger}>
<SecondarySearches interpretedParams={window.interpreted_params} />
<BikeSearches interpretedParams={window.interpreted_params} />
</ErrorBoundary>,
el
);
Expand Down
20 changes: 7 additions & 13 deletions app/javascript/scripts/api.js
Expand Up @@ -4,10 +4,10 @@

const url = urn => [process.env.BASE_URL, urn].join('/')

const serialSearchUrl = serial => url(`api/v2/bikes_search?serial=${serial}`)

const fuzzySearchUrl = serial =>
url(`api/v2/bikes_search/close_serials?serial=${serial}`)
const searchUrl = params => {
const query = queryString(params)
return url(`api/v3/search?${query}`)
}

const partialMatchSerialSearchUrl = params => {
const query = queryString(params)
Expand Down Expand Up @@ -58,13 +58,8 @@ const queryString = (passedParams = {}) => {
Public
*/

const fetchSerialResults = serial => {
const url = serialSearchUrl(serial)
return request(url)
}

const fetchFuzzyResults = serial => {
const url = fuzzySearchUrl(serial)
const fetchMatches = interpretedParams => {
const url = searchUrl(interpretedParams)
return request(url)
}

Expand All @@ -84,8 +79,7 @@ const fetchSerialExternalSearch = ({ raw_serial }) => {
}

export default {
fetchSerialResults,
fetchFuzzyResults,
fetchMatches,
fetchSerialExternalSearch,
fetchSerialCloseSearch,
fetchPartialMatchSearch
Expand Down
2 changes: 1 addition & 1 deletion app/javascript/scripts/bikes_search/BikeSearch.jsx
Expand Up @@ -79,7 +79,7 @@ class BikeSearch extends Component {
return (
<div className={wrapperClassName}>
<div className='col-md-12'>
<h3 className='no-exact-results'>
<h3 className='no-exact-results uncap'>
{this.props.t('no_matches_found_html', { serial })}
</h3>
</div>
Expand Down
6 changes: 3 additions & 3 deletions app/javascript/scripts/bikes_search/BikeSearchResult.jsx
Expand Up @@ -10,7 +10,7 @@ const BikeSerialSearchResult = ({bike}) => (

<div className="bike-information multi-attr-lists">
<h5 className="title-link">
<a href={bike.url} target="_blank">
<a href={bike.url}>
<strong>
{
bike.manufacturer_name === "unknown_brand"
Expand Down Expand Up @@ -80,12 +80,12 @@ const LocationItem = ({bike}) => {

const ResultImage = ({ bike }) => {
if (!bike.thumb || bike.is_stock_img) {
return (<a className="bike-list-image" target="_blank" href={bike.url}>
return (<a className="bike-list-image" href={bike.url}>
<img src={window.bike_placeholder_image} className="no-image"/>
</a>);
}

return (<a className="bike-list-image hover-expand" target="_blank" href={bike.url}>
return (<a className="bike-list-image hover-expand" href={bike.url}>
<img alt={bike.title} src={bike.thumb}></img>
</a>);
}
Expand Down
77 changes: 0 additions & 77 deletions app/javascript/scripts/bikes_search/SecondarySearches.jsx

This file was deleted.

65 changes: 65 additions & 0 deletions app/javascript/scripts/bikes_search/bike_searches.jsx
@@ -0,0 +1,65 @@
/* eslint import/no-unresolved: 0 */

import React, { Fragment, Component } from 'react'

import BikeSearch from './BikeSearch'
import BikeSearchResult from './BikeSearchResult'
import ExternalRegistrySearchResult from './ExternalRegistrySearchResult'

import honeybadger from '../utils/honeybadger'
import api from '../api'

const t = window.BikeIndex.translator('bikes_search')

const queries = ({ interpretedParams }) => {
const serialNumbers = interpretedParams.raw_serial
.split(/\s+|,/)
.map(s => s.trim())
.filter(s => /^\w+$/.test(s))

return serialNumbers.map(serial => ({
...interpretedParams,
serial: serial,
raw_serial: serial
}))
}

const MultipleSerialSearchHeader = ({ serial, queriesCount }) =>
queriesCount === 1 ? (
<Fragment />
) : (
<h2 className='secondary-matches uncap'>{t('serial_search', { serial })}</h2>
)

const SecondarySearches = ({ interpretedParams }) =>
!interpretedParams.serial ? (
<Fragment />
) : (

queries({ interpretedParams }).map((params, i, allQueries) => (
<Fragment key={params.serial}>
<MultipleSerialSearchHeader
serial={params.serial}
queriesCount={allQueries.length}
/>
</Fragment>
))
)


const BikeSearches = ({ interpretedParams }) => {
return <Fragment>
<BikeSearch
fetchBikes={api.fetchMatches}
searchName='search'
resultComponent={BikeSearchResult}
interpretedParams={interpretedParams}
t={window.BikeIndex.translator(
'bikes_search.search'
)}
/>
<SecondarySearches interpretedParams={interpretedParams} />
</Fragment>
}

export default BikeSearches
Expand Up @@ -35,7 +35,7 @@ const MultiSerialSearch = () => {
parallel request serials
*/
const all = await Promise.all(
uniqSerials.map(serial => api.fetchSerialResults(serial))
uniqSerials.map(serial => api.fetchMatches({serial: serial}))
)
const results = all.map(({ bikes }, index) => {
const serial = uniqSerials[index]
Expand Down Expand Up @@ -70,7 +70,7 @@ const MultiSerialSearch = () => {
parallel request fuzzy serials and merge
*/
const fuzzyAll = await Promise.all(
serialResults.map(({ serial }) => api.fetchFuzzyResults(serial))
serialResults.map(({ serial }) => api.fetchSerialCloseSearch({serial: serial}))
)
const updatedResults = fuzzyAll.map(({ bikes: fuzzyBikes }, index) => {
const serialResult = serialResults[index]
Expand Down

This file was deleted.

95 changes: 0 additions & 95 deletions app/javascript/scripts/multi_serial_search/SearchResults.test.jsx

This file was deleted.