Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 40-aria.md #43

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

geoffrey-eisenbarth
Copy link
Sponsor

Fix js links and add menu button to example.

Fix js links and add menu button to example.
@geoffrey-eisenbarth
Copy link
Sponsor Author

Oh, I'm actually not sure if the JS link changes are necessary because of this (although the js links are currently broken).

I do think adding the <button> in the menu example is helpful tho.

@fkscott
Copy link

fkscott commented Jan 28, 2024

I agree about the button. Always good to provide clarity. I do not think the JS changes are necessary in the template though. At least during testing on my local machine, copying those files into missing-js/ made those components work.

@geoffrey-eisenbarth
Copy link
Sponsor Author

@fkscott I'm not particularly familiar with the way this repo is set up. Given your change, what needs to happen for the links to work on the docs website? The release of 1.1.2?

When I have a second, I'll undo the URL changes in this PR, just juggling right now.

@fkscott
Copy link

fkscott commented Jan 28, 2024

Correct, the release of 1.1.2 should fix the links. Making the missing-js folder accessible by the website means none of the markup has to change.

Revert back to original link structure, which will be fixed in 1.1.2.
@geoffrey-eisenbarth
Copy link
Sponsor Author

Okay, should be good. I've never used GitHub to directly edit files and create PRs, so please let me know if something looks off. The only thing in this PR should be adding the button in the tabs example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants