Create ic-disable-inputs attribute #284
Conversation
|
some can check this?¿ |
|
@chg20 can check it plz! |
|
I'm a little worried that this would cause a big change in behavior. Maybe it would be OK if the element type were verified? |
|
@chg20 done! |
|
@chg20 can you take a look! thanks in advance. |
|
ping! |
|
Can I ask that this be reworked and expanded a bit? I think the right behavior is to add a new attribute: ic-disable-inputs="true" On a request we closestAttrValue('ic-disable-inputs') of the element submitting. If it is true, we search for all inputs below that element and disable them. Then you could put ic-disable-inputs on a form and have it disable all input elements below, put it on a single input, etc. Does this sound reasonable? I also would like a test for this if possible. |
|
for the hack October https://hacktoberfest.digitalocean.com/ i will working with this! |
|
awesome 👍
…On Oct 5 2019, at 10:44 am, Andres Vargas ***@***.***> wrote:
for the hack October https://hacktoberfest.digitalocean.com/ i will working with this!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#284), or mute the thread (https://github.com/notifications/unsubscribe-auth/AADSRP7O3MK7PPJSWAODVWLQNDHBVANCNFSM4HJ24BTQ).
|
|
@zodman I'm planning on doing a realase at the end of hacktober, let me know if you need any help or encouragement getting this done. I think it is a good feature! |
Bumps [lodash](https://github.com/lodash/lodash) from 4.13.1 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.13.1...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.0.5 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.0.5...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>
|
OK! I will integrate this, but it needs docs! |
…pm_and_yarn/lodash-4.17.15 Bump lodash from 4.13.1 to 4.17.15
…pm_and_yarn/handlebars-4.5.3 Bump handlebars from 4.0.5 to 4.5.3
On a request we closestAttrValue('ic-disable-inputs') of the element submitting. If it is true, we search for all inputs below that element and disable them.
Then you could put ic-disable-inputs on a form and have it disable all input elements below, put it on a single input, etc.