Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #26 to preserve overflowing containers' scroll position #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for issue #26 to preserve overflowing containers' scroll position #42

wants to merge 1 commit into from

Conversation

KDreynolds
Copy link

I took a stab at addressing the issue user @adicco mentions in issue #26, preserving scroll position in overflowing containers.

@KDreynolds
Copy link
Author

We are so back

@AlexanderArvidsson
Copy link

Personally, I would probably not do this as a top-level operation, and instead as a beforeNodeMorphed and afterNodeMorphed callback.
I think this can actually be implemented completely through the callbacks without modification to the source. Not saying it shouldn't be fixed, but the approach should probably be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KDreynolds @AlexanderArvidsson