New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peft update #557
base: main
Are you sure you want to change the base?
Peft update #557
Conversation
f0c91ee
to
96b9560
Compare
96b9560
to
b143055
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
src/petals/utils/peft.py
Outdated
|
||
class LoraLinear8bitLt(AdapterContextMixin, lora.Linear8bitLt): | ||
# TODO: Check if lora.Linear can be mixed with lora.Linear8bitLt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this checked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I checked that it worked, and the outputs were the same.
Co-authored-by: Max Ryabinin <mryabinin0@gmail.com>
Make possible to use up-to-date PEFT library.
TODO: