Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #501 : BEAR Dataset #511

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

karthikrangasai
Copy link
Contributor

Closes #501

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script biodatasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

@hakunanatasha hakunanatasha self-assigned this Apr 27, 2022
@hakunanatasha
Copy link
Collaborator

@karthikrangasai this looks good but I notice some of the relations are missing in the training data - is this a facet of the dataset (hence why the unit-tests may fail?)

@karthikrangasai
Copy link
Contributor Author

Hello @hakunanatasha ,

When I ran the tests locally, all of them passed.
Let me check once again though to verify.

@karthikrangasai
Copy link
Contributor Author

karthikrangasai commented Apr 27, 2022

Hello @hakunanatasha ,

I ran the tests again and removed some unwanted lines of code. All the tests pass.

@karthikrangasai
Copy link
Contributor Author

karthikrangasai commented May 2, 2022

@hakunanatasha , could you please review the changes to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for BEAR
2 participants