Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payment): PAYPAL-2624 Removing paypa pro payment method #2502

Closed
wants to merge 1 commit into from
Closed

feat(payment): PAYPAL-2624 Removing paypa pro payment method #2502

wants to merge 1 commit into from
+2 −278

Conversation

bc-nick
Copy link
Contributor

@bc-nick bc-nick commented May 10, 2024 •
edited

What?

Removing paypa pro payment method

Why?

This implementation is deprecated for optimise one-page checkout, because if we already have one-page checkout with paypal-pro connected and we decide to switch to optimise one-page checkout, this provider will be disabled by default

Testing / Proof

Verified by switching from one-page checkout to optimised one-page checkout

@bigcommerce/team-checkout @bigcommerce/team-payments

@bc-nick bc-nick changed the title feat(payment): PAYPAL-2624 removed paypa-pro feat(payment): PAYPAL-2624 Removing paypa pro payment method May 10, 2024
@bc-nick bc-nick marked this pull request as ready for review May 10, 2024 11:59
@bc-nick bc-nick requested review from a team as code owners May 10, 2024 11:59
serhii-tkachenko
serhii-tkachenko requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@serhii-tkachenko serhii-tkachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really sure that we should do this now, since it might brake PayPal Payments Pro for current merchants who have this integration on their stores.

@bc-nick bc-nick marked this pull request as draft May 10, 2024 12:19
@animesh1987
Copy link
Contributor

animesh1987 commented May 10, 2024 •
edited

@serhii-tkachenko maybe we can do an AQI to check for the merchants that use this integration and if the integration is done by checkout-sdk?

@serhii-tkachenko
Copy link
Contributor

PayPal Payments Pro still can be onboarded when Feature_PaypalPaymentsProUS is enabled. Also I talked with Nick and he said, that we have merchants who still use this payment provider.

@animesh1987
Copy link
Contributor

PayPal Payments Pro still can be onboarded when Feature_PaypalPaymentsProUS is enabled. Also I talked with Nick and he said, that we have merchants who still use this payment provider.

Thanks. Is that available in OOPC? I know PaypalPro is available for legacy checkout, but legacy checkout doesn't use SDK integration.

@serhii-tkachenko
Copy link
Contributor

Is that available in OOPC?

@animesh1987 Yes. You can get an ability to setup PayPal Payments Pro for OOPC by enabling Feature_PaypalPaymentsProUS in Assets manager

@bc-nick bc-nick closed this May 13, 2024
@bc-nick bc-nick deleted the PAYPAL-2624 branch May 13, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhii-tkachenko serhii-tkachenko serhii-tkachenko requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bc-nick @animesh1987 @serhii-tkachenko