feat(payment): PAYPAL-4068 added BT Fastlane address shipping selector #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4068
branch
3 times, most recently
from
8c147af
to
5e32b2c
Compare
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4068
branch
from
7fc69c3
to
51c103c
Compare
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4068
branch
from
0bcf7ef
to
c418c83
Compare
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4068
branch
4 times, most recently
from
14731b8
to
c412eb3
Compare
bc-dronov
approved these changes
May 20, 2024
serhii-tkachenko
approved these changes
May 20, 2024
| import { PaymentProviderCustomerActionCreator } from '../../../payment-provider-customer'; | ||
| import { CardInstrument } from '../../../payment/instrument'; | ||
| import { UntrustedShippingCardVerificationType } from '../../../payment/instrument/instrument'; | ||
| import ConsignmentActionCreator from '../../consignment-action-creator'; | ||
| import { ShippingInitializeOptions, ShippingRequestOptions } from '../../shipping-request-options'; | ||
| import ShippingStrategy from '../shipping-strategy'; | ||
| import { BraintreeInitializationData } from '../../../payment/strategies/braintree'; |
There was a problem hiding this comment.
Please check and fix eslint warning
| expect(braintreeIntegrationServiceMock.getBraintreeFastlane).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('updates customer', async () => { |
There was a problem hiding this comment.
Suggested change
| it('updates customer', async () => { | |
| it('updates provider customer data', async () => { |
bc-nick
approved these changes
May 20, 2024
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4068
branch
from
c412eb3
to
cf5fbd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added BT Fastlane address shipping selector
Why?
To implement paypal fastlane shipping address selector
Testing / Proof
Unit tests
Fastlane User
FastLane.User.mov
Non Fastlane User
Screen.Recording.2024-05-17.at.09.13.56.mov
Fastlane Refreshed Page
FastLane.Refreshed.Page.mov
Fastlane Changed To Non Fastlane
FastLane.User.Changed.to.Non.FastLane.mov
Canceled OTP
Canceled.OTP.mov
@bigcommerce/team-checkout @bigcommerce/team-payments