feat(payment): PAYPAL-3520 Max capture amount failure #2485
+99
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-nick
requested review from
serhii-tkachenko,
andriiVitvitskyi1990 and
bc-dronov
bc-dronov
reviewed
Apr 26, 2024
| if (isPaypalCommerceProviderError(error)) { | ||
| const paypalProviderError = error?.errors?.filter((e: any) => e.provider_error) || []; | ||
|
|
||
| return paypalProviderError[0].provider_error?.code === '2046'; |
There was a problem hiding this comment.
Maybe it would be better to create a separate constant for '2046' error? How do you think?
There was a problem hiding this comment.
Sorry for the late response. I think it is not necessary, we use this code only here and nowhere else
bc-dronov
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Handling an specific error related to max capture failure
Why?
To show the error message with an appropriate information for users
Testing / Proof
Manual testing
@bigcommerce/team-checkout @bigcommerce/team-payments