Update wc_get_page_id compatability return type #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WooCommerce core version of wc_get_page_id always returns an integer and not a string. See here: https://github.com/woocommerce/woocommerce/blob/9c83a07145ea5c451adc489f21eeaf895825b683/plugins/woocommerce/includes/wc-page-functions.php#L36-L57 Ensuring that this compatibility version of the function also returns an integer could prevent subtle issues with themes or plugins that expect `wc_get_page_id` to always return an integer. In WC core a return value of -1 means the page was not found, which seems to match the desired behavior here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This updates the compatibility version of
wc_get_page_idto always return an integer to match the behavior of WC core. The current behavior of returning a string could cause issues with themes/plugins that are expecting an integer value.Tickets / Documentation