Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of label encoder to allow storing of the model #1324

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

paulzierep
Copy link

Something was messed with my rebase. New clean PR.
This update enables the export of the label encoder as h5 model, that can be used to encode new data as well, similarly to the use of pretrained models.

@paulzierep
Copy link
Author

@bgruening @anuprulez how should the tool version be bumped here ? These tools do not follow the @TOOL_VERSION@+galaxy@SUFFIX_VERSION@ logic, they all use the @VERSION@ tag set in the main_macros.xml ?

@bgruening
Copy link
Owner

Hardcode it without macro. We need to shift to IUC standards at some point.

@anuprulez
Copy link
Contributor

@paulzierep I followed version="@VERSION@" profile="@PROFILE@" pattern while upgrading ML tools to 0.10.0. But, it should not make much difference at the moment if they will be changed according to IUC standards :)

@paulzierep
Copy link
Author

Then I would propose to use @VERSION@ from the main_macros.xml and add +galaxy@VERSION_SUFFIX@ to the tools individually

@paulzierep
Copy link
Author

added the VERSION_SUFFIX can this be merged @anuprulez @bgruening

@anuprulez
Copy link
Contributor

I think there are a few linting errors that need to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants