Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Squidpy #1318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding Squidpy #1318

wants to merge 1 commit into from

Conversation

tcollins2011
Copy link
Contributor

Implementation of squidpy spatialomics for 10x visium data analysis.

@tcollins2011
Copy link
Contributor Author

@astrovsky01 Tagging for squidpy

@pavanvidem
Copy link
Collaborator

@tcollins2011 Thanks for initiating squidpy! 🚀

It would be nice to implement each of the scverse packages similarly to the IUC implementation of Scanpy, i.e., group some related functions into a single Galaxy tool of that package. If we have a collection of tools for squidpy functions, then we can also use them for other spatial data like merfish or nanostring.

Moreover, the scverse is currently developing a new datatype called SpatialData for spatial omics. Maybe it will completely replace anndata for spatial analysis. In that case, it will become hard to adapt such tools.

@tcollins2011
Copy link
Contributor Author

I would agree that it would be useful to separate Squidpy in a similar manner to Scanpy. Right now this first pass at squidpy is only compatible with 10x visium data, however the tool can take many more inputs and we haven't fully implemented all of its end functionality. I'll continue to try and and separate the tool out as time goes on, but I'll probably need to find a way to tackle the persistent paths necessary for the image container object to work correctly within Squidpy.

Copy link
Owner

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a .shed.yml ... and probably a suite one so we can add more tools into this directory.

-l 'None'
#end if
-s spatial/tissue_hires_image.png
-x "${prefix}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single quotes

@@ -0,0 +1,154 @@
<tool id="squidpy" name="squidpy" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" python_template_version="3.5" profile="21.05">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<tool id="squidpy" name="squidpy" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" python_template_version="3.5" profile="21.05">
<tool id="squidpy" name="squidpy" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="21.05">

]]></command>
<inputs>
<!-- CHANGE FORMAT LATER -->
<param argument="--visium" type="data" format="visium.tar.gz" label="Visium dataset tarball"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A user probably does not know what a tarball is. Just Visum dataset might be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants