This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
Add action collectors to scoped component browser instances #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nie7321
force-pushed
the
component-scoped-browser-has-collector
branch
from
ba2062c
to
5451a7d
Compare
nie7321
force-pushed
the
component-scoped-browser-has-collector
branch
from
5451a7d
to
c05100a
Compare
|
Have almost same problem. I'd appreciate all the help I can get. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error from #50 by wrapping the scoped callback with another callback to inject the action collector.
It is an imperfect solution -- since
onComponentis called before the callback is evaluated in Laravel\Dusk\Browser, I cannot think of a nice way to get the correct action collector instance in place for a component'sassert()method.I could copy-paste the method definition, but that seems kinda gross and brittle. Does anyone have any ideas?