-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore meta files check using AssetMetaCheck
#49
base: main
Are you sure you want to change the base?
Conversation
use bevy::prelude::*; | ||
|
||
fn main() { | ||
App::new() | ||
.insert_resource(AssetMetaCheck::Never) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment here explaining why it's needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that this was still using bevy 0.11
. I bumped it, I guess that's gonna be alright for such a small scoped repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's very helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the Cargo.lock
file is trippin me up. I understand that it shouldn't be added to .gitignore
as it wouldn't allow users to clone this repo and instead copy paste specific files, but why is there no Cargo.lock
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm? There's a Cargo.toml in the root directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, I meant there is noCargo.lock
. Is that on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's ignored. If you build locally it'll be generated for you in the expected place :)
Addresses the issue of wasm build not working correclty and itch panicking because of missing meta files that don't exist, #48.