Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the usage of seeded RNG in examples #12544

Closed
alice-i-cecile opened this issue Mar 17, 2024 · 2 comments · Fixed by #12593
Closed

Explain the usage of seeded RNG in examples #12544

alice-i-cecile opened this issue Mar 17, 2024 · 2 comments · Fixed by #12593
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

Probably raised this in the wrong PR, since this one is meant for debug, but examples like alien cake addict (in #12515) probably deserves more mention as to why we choose to set it up that way.

Originally posted by @james7132 in #12519 (review)

Ultimately these are intended to make CI runs of our examples deterministic. We should call this out in the examples via a comment to aid learners.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples A-Math Fundamental domain-agnostic mathematical operations labels Mar 17, 2024
@rparrett
Copy link
Contributor

Some other related commentary: #12515 (comment)

@andristarr
Copy link
Contributor

I can look into this while my other PR is awaiting review.

@andristarr andristarr mentioned this issue Mar 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 26, 2024
@andristarr
Adding explanation to seeded rng used in examples (#12593)
d39ab55 
# Objective

- Fixes #12544

## Solution

- Added/updated a universally worded comment to all seeded rng instances
in our examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding explanation to seeded rng used in examples andristarr/bevy
3 participants
@rparrett @alice-i-cecile @andristarr