New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge docs-section
/docs-page
templates into docs
#1149
Merge docs-section
/docs-page
templates into docs
#1149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I wonder if we could use this same feature to merge docs-page
and docs-section
into docs-base
and just rename it to docs.html
. I want to say the primary reason we even have a separate section and page templates for the docs / book portion of the site is because it was easier and more readable than writing even more if else conditions for page and section variables, but this solves that issue.
Hehe, that's actually something I wanted to ask in Discord as it seems that those are just repeated. I was going to open a PR removing those templates and just leaving a |
docs-base.html
by using default
filterdocs-section
/docs-page
templates into docs
by using default
filter
I wanted to try an extra simplification by moving the This increases the size of the PR, but it's quite easy to follow as it's mostly repetitive changes. Let me know if you prefer this in two separate PRs, I can revert the changes. |
The scope is fine imo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I almost thought you also had to change a template variable in generate-release
, but I guess we currently don't include that in it's front matter and add it when we move it to be an actual page.
I'm tempted to slip these changes in |
Mm, tentatively I'll say that perhaps the |
I'll leave this PR as it is and I'll open the |
docs-section
/docs-page
templates into docs
by using default
filterdocs-section
/docs-page
templates into docs
This PR needs to be updated to account for the |
Merge
docs-section
/docs-page
templates intodocs
leveragingdefault
filter (allows removal of repetitiveif section … elseif page …
code).