Use Javascript mega-linter flavor

[BD103]

Closes #1087.

This configures the mega-linter CI check to use the Javascript flavor, as suggested by Trial in #1087 (comment). Flavors are customized version of the default image are smaller and more specialized.

The goal of this PR is to decrease the mega-linter runtime from 3 minutes to at least 2 minutes, so it will no longer be the slowest job. This appears to decrease the runtime for the mega-linter job from 3 minutes to <1 minute!

[mnmaita]

You beat me to it 😆 let's see how much this improves the CI times! Good callout btw.

[mnmaita]

Should we add the FAIL_IF_MISSING_LINTER_IN_FLAVOR variable in the YAML config? It says:

If set to true, MegaLinter fails if a linter is missing in the selected flavor

which could be handy if new linters are added later down the road (although that might be unlikely).

[BD103]

This appears to decrease the runtime to <1 minute, which is a definite win!

Should we add the FAIL_IF_MISSING_LINTER_IN_FLAVOR variable in the YAML config? It says:

If set to true, MegaLinter fails if a linter is missing in the selected flavor

which could be handy if new linters are added later down the road (although that might be unlikely).

That sounds like something we should definitely enable, good idea!

[mnmaita]

I don't have any objections to this change but let's see if someone else has any additional input.

[TrialDragon]

Definite improvement that makes it no longer three minutes, just approximately one.

[mockersf]

Should we add the FAIL_IF_MISSING_LINTER_IN_FLAVOR variable in the YAML config? It says:

If set to true, MegaLinter fails if a linter is missing in the selected flavor

which could be handy if new linters are added later down the road (although that might be unlikely).

Not sure I understand why? We want the linter to fail if we ask it to use a linter it doesn't have

My bad, I need to learn to better read text in all caps