Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixed typo and a mistake in the code in plugins.md #1082

Merged
merged 2 commits into from Mar 8, 2024

Conversation

Riximus
Copy link
Contributor

@Riximus Riximus commented Mar 8, 2024

Reading through the documentation I noticed a small typo.

I hope it is fine creating a PR without an issue first for this.

@Riximus
Copy link
Contributor Author

Riximus commented Mar 8, 2024

I found more in plugins.md and will update accordingly.

@Riximus Riximus marked this pull request as draft March 8, 2024 14:47
@Riximus
Copy link
Contributor Author

Riximus commented Mar 8, 2024

The newest commit fixes the order of the systems that are placed in the chain. Looking at the "ECS" page the code was in wrong order in the next page "Plugins".

ECS Page:
image

Plugins Page:
image

@Riximus Riximus marked this pull request as ready for review March 8, 2024 14:54
@Riximus Riximus changed the title docs: fixed typo in plugins.md Docs: Fixed typo and a mistake in the code in plugins.md Mar 8, 2024
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye, thank you!

@BD103 BD103 added S-Ready-For-Final-Review Ready for a maintainer to consider for merging C-Correction A typo or factual issue in what we've written labels Mar 8, 2024
@mockersf mockersf added this pull request to the merge queue Mar 8, 2024
Merged via the queue into bevyengine:main with commit 8bcb476 Mar 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Correction A typo or factual issue in what we've written S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants