Improve Bevy news feed #1073
Improve Bevy news feed #1073
Conversation
Technically we're using atom rather than RSS, minor technical difference.
|
I don't think RSS is used enough to get a place in the header From #1072 (comment), this shouldn't be needed. We could add a title in the html header link. |
|
I'm not a fan of the bright orange RSS logo; it clashes a lot with the current website design. What if we used a black + white variant that could use Bevy's theme?
What if the RSS logo was only shown on the News page and at the bottom of posts? That way it is out-of-the-way, but still discoverable. Additionally a website footer could be made, which could include the RSS link. |
We already have the atom link in the HTML head and that feature, AFAIK, isn't supported by default in any of the modern browsers (that article you mentioned in the issue is from almost 20 years ago and contains outdated info regarding browser support) and requires external extensions and tooling. I can try to find some place to put it at https://bevyengine.org/news/, but that'll take a bit more effort to make it look good.
That can work, yeah. There should be some freely available feed icon for use in that color scheme, or we can just make one ourselves if need be. |
Sounds good 👍 |
It's less intrusive than sticking the feed icon in the header and the site could use a footer.
It looks better on the site and modern. It's from the feather icons set: <https://github.com/feathericons/feather>
|
Updated it to use a neutral colored svg and reside in a website footer. |
I forgot to `git add -A`, only `git commit -a`
There was a problem hiding this comment.
I'm not sure if I like the footer in its current form, but I'm not really sure how to improve it.
I'm going to mark this as approved, but in the future I think it would be good to revisit this and see if we can rethink what goes in to the footer. (Maybe important links / contact info?)
The width and height can just be set on the elements themselves.
TrialDragon
added
the
S-Ready-For-Final-Review
Agreed. I considered adding more, but that would require a lot of design and was out of scope for this specific PR (tbh, switching to the footer was already toeing the line of the scope imo even tho I did go with it). I'll open up an issue (or maybe a discussion?) if this merged so that the footer can have design decisions made and then be improved. |
There was a problem hiding this comment.
I've resisted the footer for awhile but I do think it is probably inevitable as we expand the site (and run out of space in the headerbar).
I did change the icons to grayscale as I don't think the colors were a good fit.
I removed the "author" and "authors" redundancy by embracing "authors". I also made it default to Bevy Contributors (and removed the explicit definitions in those cases), although now that I'm thinking about it, that would probably break the RSS attribution in those cases. I'll add those lines back.
I did not realize that would work, otherwise I would've done that back when we updated to Zola 0.18.0. |
Adds a standard feed link to the footer of the page and adds the authors variable to the news pages so that the news feed will have attribution to the authors of articles. It is currently using the rss icon provided by feather icons: https://github.com/feathericons/feather/blob/main/icons/rss.svg
Closes #1072
A note: we can't use the
authorsvariable in place of our currentextra.authorvariable because it isn't available to templates. It's only for feeds as far as I know.