Use correct neither…nor construction #176
Conversation
|
@getaaron I am for changing the sentence. What do you think about this:
If you know another language, please add the fixed translation to this PR. This PR will be merged after checking the progress with the new translations effort. |
|
Is there anything preventing this work from being merged? |
|
@strand It's been a while, but IIRC I think I wanted to make sure all appropriate translations were added so the change happens everywhere, as necessary. IDK though if other languages would need this kind of change though. |
|
🤔 I think we should avoid blocking work from being merged until translations of that work is available. I'm not certain what practice one should use to ensure translations stay in sync. Perhaps we could use a comment to indicate which SHA or tag the translation is based off of, and then every update to a translation would be able to translate just the changes introduced between the tag and the current version? That way the translations could be updated not on a change level, but a release or a version level, reducing the amount of back-and-forth communication we need to have with translator volunteers. |
|
The neither/nor construct is English only. I agree, this looks good |
|
Let’s merge it! 😀 |
"neither fixtures or factories" is grammatically incorrect. This PR changes the clause to "neither fixtures nor factories".
An alternative, but more intrusive, fix would be to change the whole sentence to "When talking about unit tests the best practice is to avoid fixtures and factories entirely."
http://thewritepractice.com/how-to-use-either-neither-or-and-nor-correctly/