Make DrawMarginFrame rendering more flexible #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring makes it easier for sub-classes to implement custom rendering logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a virtual method for measuring each paint task in
DrawMarginFramewithout changing any of the actual rendering logic.This refactoring makes it easier for sub-classes to implement custom rendering logic. Sub-classes only need to override the method for the specific paint task they want to alter.
If this approach looks good, it could also be applied to other components where appropriate (though I think this is one of the more simple examples, this pattern probably wouldn't be as straightforward with other classes)