Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/formatting setup #735

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chmelevskij
Copy link
Member

This adds prettier and eslint configuration to automatically run linter on formatter as pre-commit hook.

For those ney sayers, we already have this setup for docs and no-one is complaining there, this one is copied from https://github.com/betaflight/betaflight.com

For the question Isn't sonar cloud doing this?, no it's not, it's happily reports code duplication when there is nothing change and then doesn't report real errors with logic
Screenshot 2024-04-27 at 12 46 54

Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for origin-blackbox-logviewer ready!

Name Link
🔨 Latest commit 17a9122
🔍 Latest deploy log https://app.netlify.com/sites/origin-blackbox-logviewer/deploys/662cd7ba0ba6940008890a10
😎 Deploy Preview https://deploy-preview-735--origin-blackbox-logviewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Apr 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
8.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@McGiverGim
Copy link
Member

I've been suffering this in the Configurator. I'am all for including this kind of tools, but I don't like the way it hooks with the commit. Not everybody uses the same git tools, and not all the tools shows this in the same manner. Sometimes it gives errors that are difficult to be seen for the user, and the user can take a good amount of time to find it, fix it, and pushing it.

I know the idea is to get rid of them before the PR, but it seems to me that it can discourage new contributors when they have a git error that don't understand.

I know it will not be very popular, but I prefer a script that the user can execute (or integrate with VS Code), and that we can execute as a part of our Github Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants