Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thrust Linear #729

Closed
wants to merge 5 commits into from
Closed

Add Thrust Linear #729

wants to merge 5 commits into from

Conversation

SupaflyFPV
Copy link

Hackerman is back with an attempt to add Thrust Linear value to BBE

As far as I can tell the TL value is not currently present in BBE Header fields

I've added it to the 'Miscellaneous' box if this works as hoped...

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for origin-blackbox-logviewer ready!

Name Link
🔨 Latest commit e4a5455
🔍 Latest deploy log https://app.netlify.com/sites/origin-blackbox-logviewer/deploys/6617397e7d61bf00086e02e9
😎 Deploy Preview https://deploy-preview-729--origin-blackbox-logviewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

index.html Outdated Show resolved Hide resolved
SupaflyFPV and others added 2 commits April 9, 2024 22:19
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
@SupaflyFPV
Copy link
Author

@ctzsnooze I put this parameter in the Miscellaneous box, is that an acceptable position?

It was the easiest for me to add to...

@@ -70,6 +70,7 @@ export function HeaderDialog(dialog, onSave) {
{name:'dterm_filter_type' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'},
{name:'dterm_filter2_type' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'},
{name:'pidAtMinThrottle' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'},
{name:'thrust_linear' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{name:'thrust_linear' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'},
{name:'thrust_linear' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.5.0', max:'999.9.9'},

min will need to be 4.5.0
betaflight/betaflight#12337

@nerdCopter
Copy link
Member

do you have a log with TL configured. this is all i see here:
image

@nerdCopter
Copy link
Member

i found a log containing TL, but still same empty box(es).

@SupaflyFPV
Copy link
Author

i found a log containing TL, but still same empty box(es).

thanks for taking a look. This is my first foray into BBE so will have to look deeper into how it pulls in the numbers when I get a minute...its same for me...

@nerdCopter
Copy link
Member

[...] This is my first foray [...]

check some recent/prior PR-merges.

Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

Copy link

Pull request closed automatically as inactive.

@github-actions github-actions bot closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants