New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thrust Linear #729
Add Thrust Linear #729
Conversation
✅ Deploy Preview for origin-blackbox-logviewer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
@ctzsnooze I put this parameter in the Miscellaneous box, is that an acceptable position? It was the easiest for me to add to... |
@@ -70,6 +70,7 @@ export function HeaderDialog(dialog, onSave) { | |||
{name:'dterm_filter_type' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'}, | |||
{name:'dterm_filter2_type' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'}, | |||
{name:'pidAtMinThrottle' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'}, | |||
{name:'thrust_linear' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{name:'thrust_linear' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'}, | |
{name:'thrust_linear' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.5.0', max:'999.9.9'}, |
min will need to be 4.5.0
betaflight/betaflight#12337
i found a log containing TL, but still same empty box(es). |
thanks for taking a look. This is my first foray into BBE so will have to look deeper into how it pulls in the numbers when I get a minute...its same for me... |
check some recent/prior PR-merges. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
Pull request closed automatically as inactive. |
Hackerman is back with an attempt to add Thrust Linear value to BBE
As far as I can tell the TL value is not currently present in BBE Header fields
I've added it to the 'Miscellaneous' box if this works as hoped...