-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make VARIO optional #13624
Make VARIO optional #13624
Conversation
Do you want to test this code? You can flash it directly from Betaflight Configurator:
WARNING: It may be unstable. Use only for testing! |
src/main/target/common_post.h
Outdated
#endif | ||
#else | ||
// Remove USE_VARIO if BARO or GPS is not defined. | ||
#if (!defined(USE_BARO) || !defined(USE_GPS)) && defined(USE_VARIO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to support the user's request to include vario when they additionally include either GPS or BARO, but if they provide neither, then we don't go ahead.
Maybe this should be:
// Remove USE_VARIO if neither BARO nor GPS are defined.
#if defined(USE_VARIO) && !(defined(USE_BARO) || defined(USE_GPS))
#undef USE_VARIO
#endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorted.
This should go into 4.5.1 I think also. |
This makes the use of the vario more complicated. In master, you can just use the vario feature if you have the needed sensor on board. With this PR you have to compile a version with vario explicitly/manually activated. You don't get it automatically anymore, if the requirements for its use are met. As far as I can see, it just complicates the use of Betaflight cloud builds without benefits. What is the goal of this? Excluding it doesn't even save much flash space. Please add a description to PRs so people know what you want. |
No description provided.