Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VARIO optional #13624

Closed
wants to merge 2 commits into from
Closed

Make VARIO optional #13624

wants to merge 2 commits into from

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 4.6 milestone May 4, 2024
@haslinghuis haslinghuis self-assigned this May 4, 2024
Copy link

github-actions bot commented May 4, 2024

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #13624 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

#endif
#else
// Remove USE_VARIO if BARO or GPS is not defined.
#if (!defined(USE_BARO) || !defined(USE_GPS)) && defined(USE_VARIO)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to support the user's request to include vario when they additionally include either GPS or BARO, but if they provide neither, then we don't go ahead.
Maybe this should be:

// Remove USE_VARIO if neither BARO nor GPS are defined.
#if defined(USE_VARIO) && !(defined(USE_BARO) || defined(USE_GPS))
#undef USE_VARIO
#endif

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted.

@ctzsnooze
Copy link
Member

This should go into 4.5.1 I think also.
It restores the old behaviour.

@KarateBrot
Copy link
Member

KarateBrot commented May 6, 2024

This makes the use of the vario more complicated. In master, you can just use the vario feature if you have the needed sensor on board. With this PR you have to compile a version with vario explicitly/manually activated. You don't get it automatically anymore, if the requirements for its use are met.

As far as I can see, it just complicates the use of Betaflight cloud builds without benefits.

What is the goal of this? Excluding it doesn't even save much flash space. Please add a description to PRs so people know what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants