Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Voltage detection method (#13350)" #13588

Closed
wants to merge 1 commit into from
Closed

Revert "Voltage detection method (#13350)" #13588

wants to merge 1 commit into from

Conversation

haslinghuis
Copy link
Member

This reverts commit 744ab45.

@haslinghuis haslinghuis self-assigned this Apr 26, 2024
@github-actions GitHub Actions
Copy link

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #13588 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@haslinghuis haslinghuis mentioned this pull request Apr 26, 2024
Closed
nerdCopter
nerdCopter approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving for workflow reasons only as release approaches
  • request core devs to decide

@nerdCopter
Copy link
Member

#13367 (comment) reports no change

@nerdCopter nerdCopter self-requested a review April 26, 2024 20:28
@haslinghuis haslinghuis deleted the beeper branch April 26, 2024 20:39
@haslinghuis haslinghuis restored the beeper branch April 26, 2024 20:40
@haslinghuis haslinghuis reopened this Apr 26, 2024
@pfeerick
Copy link

pfeerick commented May 6, 2024

I think #13599 and #13623 backport removes the need for this now?

@haslinghuis
Copy link
Member Author

Agree this can be closed now

@haslinghuis haslinghuis closed this May 6, 2024
@haslinghuis haslinghuis deleted the beeper branch May 6, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

Assignees

@haslinghuis haslinghuis

Labels
For Test Purposes Only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haslinghuis @nerdCopter @pfeerick