Make Cppcheck happier revived

[haslinghuis]

• Revival of Make Cppcheck happier #11175

Credits to @daleckystepan

[github-actions]

Do you want to test this code? You can flash it directly from Betaflight Configurator:

• Simply put #13566 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

[haslinghuis]

Notes:

• /src/main/drivers/timer.c does not exist.
• Did not resolve changes in src/main/vcpf4/usbd_cdc_vcp.c

[nerdCopter]

I set 4.6 Milestone on this only because the prior PR had it. If this is incorrect, please change. This PR changes many files -- maybe proceed with caution.

[nerdCopter]

how to test? cppcheck ./src/? cpp version dependent?

[ledvinap]

how to test? cppcheck ./src/? cpp version dependent?

You can check ublox, that is only noticeable change.

Rest is mostly const and decreasing variable scope, no build errors is enough

[haslinghuis]

Can we get this merged please.

[KarateBrot]

You don't need to close the original PR and make a new one, you can edit the original

[haslinghuis]

@KarateBrot did not want to mangle the original PR without @daleckystepan approval to do so - so this PR is in his honor.

[nerdCopter]

you can also git commit co-authors s that his namesake would be included. https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

[haslinghuis]

@blckmn please can we get this merged #11175 (comment)

[blckmn]

@haslinghuis I can't see where you've co-authored this?

[haslinghuis]

Trying but does not work

[haslinghuis]

Any suggestion?

[blckmn]

Any suggestion?

The easiest way was to pull the original commits from the original PR, and make your changes, raise a commit for those changes (to your local repo), and then raise a new PR. That way the original commits will be authored correctly.

i.e. Pulling the PR (using the /pull/XXX/head method), rebasing as required, and adding your new commits.

Here is githubs official position on inactive pull requests and editing locally: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[blckmn]

Please add the co-authorship.

[blckmn]

Any suggestion?

Probably the easiest way now is to reset the branch, back to where it forks for this branch (from master), and then create an entirely new commit, retaining any commit commits and adding the co-authorship in the process - then force pushing.

[haslinghuis]

Did not cherry-pick but entirely did this manually - as there were too many conflicts - it was easier to go from scratch.

It took hours while testing and building to get it right anyhow.

EDIT: just amend with co-author did the trick

Added co-author