Try to init MSP OVERRIDE frame with correct default values #13524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with default values in MSP override init frame, it makes the drone spin like crazy. In this PR the idea is to provide typical default values for ROLL, PITCH, and YAW like in betaflight configurator interface. I'm not sure if it's the best way to handle it and how to take into account that user can configure channel mapping (e.g. AETR, et).
In the previous version of the code (v4.4) it seems that default behavior was to return proper default values. The drones are crashing only with 4.5 and not with 4.4.
Looks like the issue was introduced in #13352
Before that change, in a moment between MSP_OVERRIDE is ON and the first MSP packet is received, the drone was not receiving new commands. But with this change, the drone receives commands that consist of 885, 885, 885... It makes the drone unstable within a fraction of a second, and eventually, it falls down.
The correct behavior would be to keep previous values or at least to have correct default values.