Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing chapter structure and add detail #146

Merged
merged 11 commits into from
May 24, 2024

Conversation

foster999
Copy link
Contributor

No description provided.

@foster999 foster999 linked an issue Apr 20, 2023 that may be closed by this pull request
@foster999 foster999 marked this pull request as draft April 20, 2023 16:23
@foster999
Copy link
Contributor Author

foster999 commented May 31, 2023

Need to improve guidance on integration testing. Should be above unit test level (i.e. not focused on values that are created by individual functions). Better to look at schema of data or properties of data (e.g. missingness)

Discuss trade-off when integration tests go into more detail (regression test), making test fragile

Need to discuss acceptance tests and how these should be automated
Need to change the wording of the checklist criteria to something like "It's easy to identify which UATs have passed against a given change in the code version control".
Need guidance for migrating from manual testing to documented outcomes near the code, to automated tests
"Near code" means that we can get from code to the tests that have passed (the acceptance criteria)

When testing exceptions, test the specific exception type and error message if used

@gisellerosetta gisellerosetta marked this pull request as ready for review May 22, 2024 11:34
@gisellerosetta gisellerosetta self-requested a review May 22, 2024 11:34
Copy link
Contributor

@gisellerosetta gisellerosetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, really thorough - have added a comment onto #87 so the additional work to do on this isn't lost as we keep developing the chapter.

Many thanks @foster999 !

@sarahcollyer sarahcollyer merged commit 5194905 into main May 24, 2024
1 check passed
@sarahcollyer sarahcollyer deleted the 87-expand-testing-chapter branch May 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants