Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Add dev dependencies to user setup.cfg #88

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Conversation

joshlynchONS
Copy link
Contributor

@joshlynchONS joshlynchONS commented Apr 5, 2023

Summary

Add an optional dev dependencies section to the users setup file. This helps the user manage the different dependencies between their package users and developers

Checklists

This pull/merge request meets the following requirements:

Comments have been added below around the incomplete checks.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #88 (3c48701) into main (1b0652b) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   59.25%   59.25%           
=======================================
  Files           4        4           
  Lines          54       54           
=======================================
  Hits           32       32           
  Misses         22       22           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

{{ cookiecutter.repo_name }}/Makefile Outdated Show resolved Hide resolved
@@ -23,6 +23,14 @@ using:
pip install -e .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the pip install here or should it be make install?

Also there is a bit at the bottom of the README.md which say about doing pip install requirements. Can this be replaced / removed and can you check in the other docs it's not there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced the requirements at the bottom to use the makefile. I've left pip install as an option as well as the Makefile. Do you think I should just keep the Makefile install?

@Jacobb164 Jacobb164 merged commit ce8e083 into main Jun 12, 2023
44 checks passed
@Jacobb164 Jacobb164 deleted the add_dev_dependencies branch June 12, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants