-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: Add dev dependencies to user setup.cfg #88
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 59.25% 59.25%
=======================================
Files 4 4
Lines 54 54
=======================================
Hits 32 32
Misses 22 22 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -23,6 +23,14 @@ using: | |||
pip install -e . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the pip install here or should it be make install?
Also there is a bit at the bottom of the README.md which say about doing pip install requirements. Can this be replaced / removed and can you check in the other docs it's not there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced the requirements at the bottom to use the makefile. I've left pip install as an option as well as the Makefile. Do you think I should just keep the Makefile install?
Summary
Add an optional dev dependencies section to the users setup file. This helps the user manage the different dependencies between their package users and developers
Checklists
This pull/merge request meets the following requirements:
docs
folderComments have been added below around the incomplete checks.