Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Null Safety #264

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

Arkangel12
Copy link

I help a little bit by migrating this package to null safety please take a look.

I copy the code from your other packages (they were too old) and added in this one, the others can be migrated later I just have enough time to do it like this.

please double-check if it is ok to move this to version 2.0.0 this was a huge refactor and some code was enhanced (I added pedantic) but it also can only be changed to 1.2.0 i leave this to you.

let me know what do you think 👍

running with null safety

@allanwolski
Copy link

+1

@szymly
Copy link

szymly commented Apr 9, 2021

@jzoom can it be merged anytime soon? It is blocking my release

@Nobler
Copy link

Nobler commented May 10, 2021

@Arkangel12 Could you pls publish the package onto pub.dev? The repo owner may not continue the repo anymore.

@allanwolski
Copy link

@jzoom, @pepsighan, @iChenLei, @jogboms

Could anyone review and merge this PR please?

@emlynmac
Copy link

Any chance to get this merged soon? It's one of the dependencies holding me up from migrating to null-safety.

@iChenLei
Copy link
Contributor

@allanwolski @szymly @emlynmac @Nobler I am tring to contact with jzoom, and push the merge action as soon as possible.

@Nobler
Copy link

Nobler commented May 13, 2021

@iChenLei Any updates?

@iChenLei
Copy link
Contributor

2021-05-13 11 07 02

@Nobler It's hard to contact with @jzoom ,and I found him in the QQ(Tencent QQ) paltform finally. I am negotiating with him, but no promised that i can push the merge action.

@Nobler
Copy link

Nobler commented May 13, 2021

2021-05-13 11 07 02

@Nobler It's hard to contact with @jzoom ,and I found him in the QQ(Tencent QQ) paltform finally. I am negotiating with him, but no promised that i can push the merge action.

Many thanks anyway. I will temporarily depend directly on the package stored in @Arkangel12 Github. Any others can do that before this pr will be merged:

flutter_swiper:
  git:
    url: git@github.com:Arkangel12/flutter_swiper.git
    ref: master

@iChenLei
Copy link
Contributor

iChenLei commented May 26, 2021

@Nobler @allanwolski @Arkangel12 @emlynmac I am sorry to say this PR is look likes can't be merged. Please use alternative solution(e.g. flutter_swiper_null_safety or other swiper library) or use this workaround suggestion #264 (comment).

I contact with jzoom first time at 2021.05.13. After two weeks he still not merge this PR.

  1. He has no time to maintain opensource project
  2. He forgot his Github Account password.

So I left this comment for everyone who need flutter-swiper and null-safety support, please use alternative solution. Thanks

@Nobler
Copy link

Nobler commented May 26, 2021

@iChenLei Thank you so much for your help! This pr will be merged soon, I guess.👀

哈哈,难为你了,忍不住用母语感谢你。目前看应该还有希望。👀

@hpoul
Copy link

hpoul commented May 30, 2021

@iChenLei @jzoom he could just upload a fixed version to pub, no need for github 😅️ maybe it would be worth thinking about proposing the package to be transferred to https://github.com/fluttercommunity/transfer-guide 🤔️

@nmzz209741
Copy link

any updates on this?

@SalahAdDin
Copy link

This is died it seems.

@TheAnkurPanchani
Copy link

I have forked this repo and merged most of PRs into it (including this one). You can find the package here: https://pub.dev/packages/card_swiper

@SalahAdDin
Copy link

SalahAdDin commented Jun 7, 2021

I have forked this repo and merged most of PRs into it (including this one). You can find the package here: https://pub.dev/packages/card_swiper

Unfortunately, you have no open issues, it is working fine for now, but it still has some problems yets a we warned in two issues in another fork repository: pzentenoe/flutter_card_swipper#4, pzentenoe/flutter_card_swipper#3 (comment)

@TheAnkurPanchani
Copy link

Thanks @SalahAdDin,
I will have a look.

@lianyagang
Copy link

@iChenLei @jzoom he could just upload a fixed version to pub, no need for github 😅️ maybe it would be worth thinking about proposing the package to be transferred to https://github.com/fluttercommunity/transfer-guide 🤔️

You can try the following version

dependencies:
flutter_swiper_null_safety: ^1.0.2

@lianyagang
Copy link

Thanks @SalahAdDin,
I will have a look.

You can try the following version

dependencies:
flutter_swiper_null_safety: ^1.0.2

@lianyagang
Copy link

@iChenLei @jzoom he could just upload a fixed version to pub, no need for github 😅️ maybe it would be worth thinking about proposing the package to be transferred to https://github.com/fluttercommunity/transfer-guide 🤔️

You can try the following version

dependencies:
flutter_swiper_null_safety: ^1.0.2

@SalahAdDin
Copy link

@lianyagang @TheAnkurPanchani @pzentenoe why don't you try to gather all your sources and work on a unique fork?

@lianyagang
Copy link

@lianyagang @TheAnkurPanchani @pzentenoe why don't you try to gather all your sources and work on a unique fork?

i think u can try use
dependencies:
flutter_swiper_null_safety: ^1.0.2

this pub gather all resource best wish for u

@smith1996
Copy link

Can anyone confirm if I can use this dependency 'flutter_swiper' with null-safety support? I saw in the dev pub that it doesn't support null-safety. How do I make it support null safety?

@lianyagang
Copy link

Can anyone confirm if I can use this dependency 'flutter_swiper' with null-safety support? I saw in the dev pub that it doesn't support null-safety. How do I make it support null safety?

use it flutter_swiper_null_safety: ^1.0.2

@smith1996
Copy link

@lianyagang thanks for the answer. The dependency that you suggest is a fork of "flutter_swiper"? What is your opinion about "card_swiper"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet