Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

change is not implemented #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change is not implemented #200

wants to merge 1 commit into from

Conversation

uwej711
Copy link
Contributor

@uwej711 uwej711 commented Dec 18, 2013

Not sure but this looks like a backbone change ...

@dbu
Copy link

dbu commented Apr 17, 2014

@bergie looks like the travis setup with saucelabs is broken... could you investigate?

@bergie
Copy link
Owner

bergie commented Jan 19, 2015

@dbu travis setup is fixed now

@dbu
Copy link

dbu commented Jan 21, 2015

@bergie great. can you click on the failed build link and restart the build so we can see if this works? and review the PR and merge if its good?

@bergie
Copy link
Owner

bergie commented Jan 21, 2015

@dbu did you rebase? The build fixes are only in master

@uwej711
Copy link
Contributor Author

uwej711 commented Jan 21, 2015

Rebased

@dbu
Copy link

dbu commented Jan 21, 2015

strange. this still stops at a build error, but travis says that the master is building correctly. @uwej711 can you re-check if you have everything from upstream master?

@uwej711
Copy link
Contributor Author

uwej711 commented Jan 21, 2015

Checked, the only difference I see doing git diff origin/master uwej711/change is the same as here ...

@dbu
Copy link

dbu commented Jan 21, 2015

@bergie any idea what is causing the problem on travis then?

@bergie
Copy link
Owner

bergie commented Jan 21, 2015

@dbu @uwej711 well, the latest fails with Bower trying to install rangy: https://travis-ci.org/bergie/create#L231

Checking that, it seems this is now replaced by rangy-official

@bergie
Copy link
Owner

bergie commented Jan 22, 2015

@dbu @uwej711 builds are passing now on master again, please rebase

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants