Refactor AuthProvider to throw original error #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the AuthProvider to throw the original error instead of a generic 'Login error: invalid credentials' error. This provides more specific error messages to the user. Specifically, it allows access to the error code needed for MFA sign ins. References: https://firebase.google.com/docs/reference/node/firebase.auth.multifactorerror https://firebase.google.com/docs/auth/web/multi-factor#signing_users_in_with_a_second_factor
Update the AuthProvider.ts to handle multi-factor authentication while maintaining previous behaviour for all other errors. If the error code is 'auth/multi-factor-auth-required', it logs the second factor challenge required and throws the error. Otherwise, it logs the invalid credentials and throws a generic error message.
|
@benwinding please let me know if you need any other elements to consider merging this PR. I would be glad to write some documentation around the MFA scenario or adding an example if needed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the AuthProvider to throw the original error instead of a generic 'Login error: invalid credentials' error when dealing with Multi-Factor users.
This allows access to the
error codeandresolverneeded for MFA sign ins.References:
https://firebase.google.com/docs/reference/node/firebase.auth.multifactorerror https://firebase.google.com/docs/auth/web/multi-factor#signing_users_in_with_a_second_factor