Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): make sure to parse pip_args in correct order #4722

Merged
merged 1 commit into from May 10, 2024
Merged

fix(build): make sure to parse pip_args in correct order #4722

merged 1 commit into from May 10, 2024

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented May 9, 2024

all pip args should be parse after install, such that it will work in conjunction with -r

This will fail if user pass in pip_args in bentofile.yaml, or via the API call.

@aarnphm
fix(build): make sure to pass pip_args before -r
e9df534 
Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner May 9, 2024 22:21
@aarnphm aarnphm requested review from ssheng and frostming and removed request for a team May 9, 2024 22:21
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Code Coverage

Package Statements
bentoml 64.24% (11006 / 17132)
Summary 64.24% (11006 / 17132)

@frostming frostming merged commit 9221551 into main May 10, 2024
41 of 43 checks passed
@frostming frostming deleted the fix/correct-install-options branch May 10, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming approved these changes

@ssheng ssheng Awaiting requested review from ssheng ssheng is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aarnphm @frostming