Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: annotation preparation list iteration bug #4701

Merged

Conversation

adamliter
Copy link
Contributor

@adamliter adamliter commented May 3, 2024

What does this PR address?

Fixes bug reported in Slack.

Before submitting:

@adamliter adamliter requested a review from a team as a code owner May 3, 2024 00:18
@adamliter adamliter requested review from ssheng and removed request for a team May 3, 2024 00:18
@adamliter adamliter changed the title [WIP]: fix: annotation preparation list iteration bug [WIP] fix: annotation preparation list iteration bug May 3, 2024
@adamliter adamliter force-pushed the adamliter/fix-validator-schema-generation branch 3 times, most recently from 90f7168 to ca994e1 Compare May 3, 2024 06:05
@adamliter adamliter changed the title [WIP] fix: annotation preparation list iteration bug fix: annotation preparation list iteration bug May 3, 2024
src/_bentoml_sdk/_pydantic.py Outdated Show resolved Hide resolved
src/_bentoml_sdk/_pydantic.py Outdated Show resolved Hide resolved
src/_bentoml_sdk/_pydantic.py Outdated Show resolved Hide resolved
src/_bentoml_sdk/_pydantic.py Outdated Show resolved Hide resolved
@adamliter adamliter force-pushed the adamliter/fix-validator-schema-generation branch from e076634 to cdab16a Compare May 6, 2024 01:04
@adamliter adamliter force-pushed the adamliter/fix-validator-schema-generation branch from cdab16a to 640e5e2 Compare May 6, 2024 01:34
@frostming frostming merged commit 75acab0 into bentoml:main May 6, 2024
42 checks passed
@adamliter adamliter deleted the adamliter/fix-validator-schema-generation branch May 6, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants