fix: correct the default value of timeout-keep-alive (#4717)

* fix: correct the default value of timeout-keep-alive Signed-off-by: Frost Ming <me@frostming.com>
bentoml · May 8, 2024 · 66321b8 · 66321b8
1 parent 09db40b
commit 66321b8
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/src/_bentoml_impl/worker/service.py b/src/_bentoml_impl/worker/service.py
@@ -85,7 +85,7 @@
 @click.option(
     "--timeout-keep-alive",
     type=int,
-    default=None,
+    default=5,
     help="Close Keep-Alive connections if no new data is received within this timeout.",
 )
 @click.option(

diff --git a/src/bentoml_cli/serve.py b/src/bentoml_cli/serve.py
@@ -192,9 +192,7 @@ def cli():
     @click.option(
         "--timeout-keep-alive",
         type=int,
-        default=None,
         help="Close Keep-Alive connections if no new data is received within this timeout.",
-        show_default=True,
         hidden=True,
     )
     @click.option(

diff --git a/src/bentoml_cli/start.py b/src/bentoml_cli/start.py
@@ -139,7 +139,6 @@ def cli():
     @click.option(
         "--timeout-keep-alive",
         type=int,
-        default=None,
         help="Close Keep-Alive connections if no new data is received within this timeout.",
     )
     @click.option(

diff --git a/src/bentoml_cli/worker/http_api_server.py b/src/bentoml_cli/worker/http_api_server.py
@@ -86,7 +86,7 @@
 @click.option(
     "--timeout-keep-alive",
     type=click.INT,
-    default=None,
+    default=5,
     help="Close Keep-Alive connections if no new data is received within this timeout.",
 )
 @click.option(