Allow to get high quality pictures. #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the quality of the picture was taken from the video html component, which in general will lead to pretty low resolution. Instead of that, we add a video constraint, so if possible the video will project a stream with height of at least 1080p. We store global height and width from the selected stream and set the canvas to those when snap is taken.
The function of the webcam isn't modified in this commit we just use screen measurements to give video component better defaults which will maybe be closer to the use case in which it is used. Also if the screen resizes we should take care of the video resizing.
MV-GH
added a commit
to MV-GH/webcam-easy
that referenced
this pull request
Dec 23, 2021
Allow to get high quality pictures bensonruan#29 This was easier than actually building upon the pr
vetas91
reviewed
Jan 11, 2022
| @@ -53,14 +59,16 @@ class Webcam { | |||
| } else { | |||
| videoConstraints.deviceId = { exact: this._selectedDeviceId}; | |||
| } | |||
| /* Try to get a media stream that takes at least 1080p pictures */ | |||
| videoConstraints.height = { min: 1080 } | |||
There was a problem hiding this comment.
min means minimum supported resolution. So if you have smaller resolution camera you will not see it. I think here could be used ideal .
To require a capability, use the keywords min, max, or exact
https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the quality of the picture was taken from the video
html component, which in general will lead to pretty low resolution.
Instead of that, we add a video constraint, so if possible the video will
project a stream with height of at least 1080p. We store global height
and width from the selected stream and set the canvas to those when snap
is taken.