Fix latest migration not affecting GoodJob.migrated?
#1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
update-migrated-check-with-latest-migration
branch
from
37f2c2e
to
fd00081
Compare
|
Thanks for catching this! And sorry about the delay; just got back from vacation 🌴 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test did not catch this because the migration in the generator migration folder is named incorrectly: it will not be the last migration generated and as such the test just checks that the previous migration was handled (which it is).
I also added a test that ensures that future migrations are named correctly: They must have a unique number prefix. This test fails when the renaming is undone since the prefix 10 is used two times.