Test migrations reverse cleanly

[DanielHeath]

Initial cut at the check mentioned in
#1161 (comment)

[bensheldon]

Do you think you could fit this test into the existing generators spec? I worry about my ability to maintain a shell script. Here's an example:

good_job/spec/generators/good_job/update_generator_spec.rb

Line 38 in ae74482

it 'produces an idempotent schema.rb when run with install generator' do

[DanielHeath]

Shouldn't be too hard to port - I just grabbed the one I already had written.

[DanielHeath]

Oh, actually - the test suite will be holding an open database connection, so you can't drop/recreate the database.

[bensheldon]

hmmm, I think it might be possible to disconnect! the current connection(s):

good_job/spec/support/database_cleaner.rb

Lines 9 to 10 in ae74482

	ApplicationRecord.connection_handler.clear_active_connections!
	ApplicationRecord.connection_pool.disconnect

I dunno if that's enough though to fully drop the database 🤞🏻

[DanielHeath]

Yeah, likely possible. I probably won't get to look at this in detail until... [checks calendar] early Feb