Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: gthread is a sync worker #2686

Merged
merged 2 commits into from Oct 15, 2022
Merged

docs: gthread is a sync worker #2686

merged 2 commits into from Oct 15, 2022

Conversation

jpmckinney
Copy link
Contributor

@benoitc
Copy link
Owner

benoitc commented Jun 20, 2022

gthread is not an asyncio worker but is an async worker. That should proabbly fiexed by adding it as a separate async worker. Though I am not sure why we document it. We should rather always use it using the threads setting. I am inclined to move that doc in the setting then.

@benoitc
Copy link
Owner

benoitc commented Aug 6, 2022

the gthreath work is not an asyncio worker but still an async worker though; i know it was a long time but maybe you can make the change to move that information to Async workers? I will keep it open .

@jpmckinney
Copy link
Contributor Author

I've created a subsection of Async workers for Gthread workers.

@benoitc benoitc merged commit 54c8beb into benoitc:master Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants