Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --server_name and --no_server_name options #825 #1384

Closed
wants to merge 2 commits into from
Closed

Add --server_name and --no_server_name options #825 #1384

wants to merge 2 commits into from

Conversation

mathiasverhoeven
Copy link

Set --server_name to return a different HTTP Server response header than gunicorn/19.6.0.
Set --no_server_name to no longer return the header.

…eader in the response, and `no_server_name` to disable returning the `Server` header.
@benoitc
Copy link
Owner

benoitc commented Nov 6, 2016

Thanks for the patch. I'm not sure I like the idea to add another option for gunicorn. Maybe just removing the signature is enough? Why would like someone replace the signature of Gunicorn?

@tilgovi
Copy link
Collaborator

tilgovi commented Nov 7, 2016

I'm fine for both options, but the CLI flags should be hyphenated, not snake_case, to be consistent with the existing flags.

@tilgovi
Copy link
Collaborator

tilgovi commented Nov 7, 2016

My mistake. The CLI flags are hyphenated, just not in the documentation.

server_name
~~~~~~~~~~~~~~~~~~~

* ``--server_name STRING``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below, is what I am referring to when I talk about hyphenation.

``--server-name STRING``

No?

@mathiasverhoeven
Copy link
Author

@benoitc I mainly wanted to add the option to choose between no header, gunicorn and gunicorn/19.6.0. But I agree that just being able to remove the header would address #825.
Would you be ok with just adding --no_server_name?

@tilgovi Thanks I will adjust the docs!

@benoitc
Copy link
Owner

benoitc commented Jan 21, 2017

why are you closjng the issue? has it been solved?

@RKursatV
Copy link

RKursatV commented Jul 7, 2020

It's been 4 years and still no solution? Too bad

@benoitc
Copy link
Owner

benoitc commented Jul 7, 2020

@RKursatV it has been decided to not do it. The version part has been removed from the name. There is another ticket about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants