-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bollinger Bands can now accept different smoothing (Moving Averages) #662
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
===========================================
- Coverage 100.00% 97.87% -2.13%
===========================================
Files 36 36
Lines 2290 2357 +67
Branches 248 249 +1
===========================================
+ Hits 2290 2307 +17
- Misses 0 50 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @o-nazaruk, do you need any help resolving the code conflicts or writing tests for it? |
Hey @o-nazaruk, are you still interested in getting this merged? I think it is a very good change that you proposed here. :) |
Hello @bennycode ! I haven't had a chance to have the tests developed for now. It's been quite busy for me haha. |
@o-nazaruk can you create a new PR that add the |
Hi @o-nazaruk, I am trying to fix your PR to match the latest "main" branch. One thing that I noticed is that you turned |
Checklist for new indicators
BigIndicatorSeries
NumberIndicatorSeries
getResult
are presentsrc/index.ts
startBenchmark.ts
README.md