Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new label rendering mode "aside" to render labels in two vertical stacks instead of around the circle. #161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mnori
Copy link

@mnori mnori commented Aug 6, 2018

I described an issue in #160 where clusters of small segments at the bottom of the pie cause label lines to overlap:

borked

I couldn't work out how to fix this and keep the circular label positioning, but did end up creating a new alternative label positioning mode called "aside" where the labels are rendered as two vertically aligned lists, this gets rid of the problem:

worky

The new rendering mode can be activated with a config option:

{	
	...
	"labels": {
		"lines": {
			"enabled": true,
			"color": "#777777",
			"style": "aside" // <- new style option
		}
	}
	...
}

Demo of the bug and the new "aside" rendering mode can be found here: https://codepen.io/wildtype/pen/ajjrmr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant