Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update d3pie.js #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sebinkuriakose
Copy link

Fixing 'ReferenceError: pie is not defined'

@benkeen
Copy link
Owner

benkeen commented Apr 8, 2017

Hi @sebinkuriakose, thanks for the PR! Under what circumstances does that error occur? Could you provide a few more details on how to reproduce?

@kashiif
Copy link

kashiif commented May 17, 2017

Thanks for the awesome work.

I faced this with following stack trace:

Uncaught ReferenceError: pie is not defined
    at Object.maybeCloseOpenSegment (core-libs.min-a77ef77….js:8)
    at Object.openSegment (core-libs.min-a77ef77….js:8)
    at SVGGElement.<anonymous> (core-libs.min-a77ef77….js:8)
    at SVGGElement.<anonymous> (d3.min.js:2)

To reproduce, click on a segment of a piechart. (Also reproducible on website charts as well)

@Spekou
Copy link

Spekou commented Jul 10, 2017

Hello,

I am facing the same issue.
I have several charts shown in the same page so I can't name them all "pie".

When will this be available in master version ?

@irimiab
Copy link

irimiab commented Jul 13, 2017

Facing the same issue. It can be reproduced when you are trying to use the d3pie object on a div with another ID than "pie":

        var pie = new d3pie("mypie", {
		header: {
			title: {
				text: "A Very Simple Pie",
				fontSize: 30
			}
		},
		data: {
			content: [
				{ label: "JavaScript", value: 264131 },
				{ label: "Ruby", value: 218812 },
				{ label: "Java", value: 157618}
			]
		}
	});

@CDluznie
Copy link

Same problem, any news when the PR will be merged ?

@gabemeola
Copy link

👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants